Re: [HACKERS] Custom compression methods - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Custom compression methods
Date
Msg-id CA+TgmoaMt0gHY3hGS1KL86JaOy5+rxR0FF0ZGBRoRz0CHPd0Lw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Custom compression methods  (Andres Freund <andres@anarazel.de>)
Responses Re: [HACKERS] Custom compression methods  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On Fri, Mar 19, 2021 at 5:29 PM Andres Freund <andres@anarazel.de> wrote:
> On 2021-03-19 22:19:49 +0100, Tomas Vondra wrote:
> > Yeah. And why does it even require pkg-config, unlike any other library
> > that I'm aware of?
>
> IMO it's fine to require pkg-config to simplify the configure
> code. Especially for new optional features. Adding multiple alternative
> ways to discover libraries for something like this makes configure
> slower, without a comensurate benefit.

So, would anyone like to propose a patch to revise the logic in a way
that they like better?

Here's one from me that tries to make the handling of the LZ4 stuff
more like what we already do for zlib, but I'm not sure if it's
correct, or if it's what everyone wants.

Thoughts?

--
Robert Haas
EDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Gilles Darold
Date:
Subject: Re: [PATCH] Hooks at XactCommand level
Next
From: Tom Lane
Date:
Subject: Re: Bringing some sanity to RestoreGUCState()