Re: pgsql: Fix minor problems with non-exclusive backup cleanup. - Mailing list pgsql-committers

From Robert Haas
Subject Re: pgsql: Fix minor problems with non-exclusive backup cleanup.
Date
Msg-id CA+TgmoaHJoYy+N5+0prqo5xuBNrQ5-KtW_Vmnm+Wgg84aC3GPg@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Fix minor problems with non-exclusive backup cleanup.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Fix minor problems with non-exclusive backup cleanup.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Thu, Aug 6, 2020 at 2:19 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <rhaas@postgresql.org> writes:
> > Fix minor problems with non-exclusive backup cleanup.
>
> Seems like there's an extra space in this error message in
> do_pg_abort_backup:
>
> +   if (emit_warning)
> +       ereport(WARNING,
> +               (errmsg("aborting backup due to backend exiting before pg_stop_back up was called")));

Ah, crap. Peter fixed that before, and I forgot to include it when
back-patching.

> Also, while I'm bugging you: it wasn't quite clear from the thread
> whether this is alone sufficient to fix the user-visible issue
> reported by Bharath Rupireddy, or whether we still need to change
> the JIT logic as well to do that.

I believe it suffices, but see also the commit I pushed to master.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Register llvm_shutdown using on_proc_exit, not before_shmem_exit
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Fix minor problems with non-exclusive backup cleanup.