Re: pgsql: Fix minor problems with non-exclusive backup cleanup. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix minor problems with non-exclusive backup cleanup.
Date
Msg-id 2636501.1596737986@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Fix minor problems with non-exclusive backup cleanup.  (Robert Haas <rhaas@postgresql.org>)
Responses Re: pgsql: Fix minor problems with non-exclusive backup cleanup.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
Robert Haas <rhaas@postgresql.org> writes:
> Fix minor problems with non-exclusive backup cleanup.

Seems like there's an extra space in this error message in
do_pg_abort_backup:

+   if (emit_warning)
+       ereport(WARNING,
+               (errmsg("aborting backup due to backend exiting before pg_stop_back up was called")));

Also, while I'm bugging you: it wasn't quite clear from the thread
whether this is alone sufficient to fix the user-visible issue
reported by Bharath Rupireddy, or whether we still need to change
the JIT logic as well to do that.

            regards, tom lane



pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Fix minor problems with non-exclusive backup cleanup.
Next
From: Robert Haas
Date:
Subject: pgsql: Register llvm_shutdown using on_proc_exit, not before_shmem_exit