Re: libpq: PQcmdStatus, PQcmdTuples signatures can be painlessly improved - Mailing list pgsql-hackers

From Robert Haas
Subject Re: libpq: PQcmdStatus, PQcmdTuples signatures can be painlessly improved
Date
Msg-id CA+Tgmoa9YKtbHgpBGd-Jtnz12yxdUjQ8WizUaLJp04r341etuw@mail.gmail.com
Whole thread Raw
In response to libpq: PQcmdStatus, PQcmdTuples signatures can be painlessly improved  (Alex Goncharov <alex-goncharov@comcast.net>)
Responses Re: libpq: PQcmdStatus, PQcmdTuples signatures can be painlessly improved  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
On Tue, Dec 13, 2011 at 7:55 AM, Alex Goncharov
<alex-goncharov@comcast.net> wrote:
> If the above change causes a warning in a client code, so much the
> better: the client code is doing something unreasonable like the "*s"
> assignment in my example above.

Or they just haven't bothered to decorate their entire code-base with
const declarations.

I suppose it's probably worth doing this, but I reserve the right to
be unexcited about it.  At a minimum, I dispute the application of the
term "painless" to any change involving const.

If you want this patch to be considered for application, you should
post an updated patch which includes the necessary doc changes and add
a link to it here:

https://commitfest.postgresql.org/action/commitfest_view/open

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: LibreOffice driver 1: Building libpq with Mozilla LDAP instead of OpenLDAP
Next
From: Robert Haas
Date:
Subject: Re: Command Triggers