Re: [BUGS] BUG #12989: pg_size_pretty with negative values - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [BUGS] BUG #12989: pg_size_pretty with negative values
Date
Msg-id CA+Tgmoa8XC=nqDBPMvWxGyfH1r1VpiMj98JcNYYPc55xdjotiA@mail.gmail.com
Whole thread Raw
In response to Re: [BUGS] BUG #12989: pg_size_pretty with negative values  ("Adrian.Vondendriesch" <Adrian.Vondendriesch@credativ.de>)
Responses Re: [BUGS] BUG #12989: pg_size_pretty with negative values  (Adrian Vondendriesch <adrian.vondendriesch@credativ.de>)
List pgsql-hackers
On Thu, Nov 5, 2015 at 4:19 PM, Adrian.Vondendriesch
<Adrian.Vondendriesch@credativ.de> wrote:
> New patch attached and rebased on HEAD
> (8c75ad436f75fc629b61f601ba884c8f9313c9af).

I've committed this with some modifications:

- I changed the comment for the half_rounded() macros because the one
you had just restated the code.
- I tightened up the coding in numeric_half_rounded() very slightly.
- You didn't, as far as I can see, modify the regression test schedule
to execute the files you added.  I consolidated them into one file,
added it to the schedule, and tightened up the SQL a bit.

Thanks for the patch, and please let me know if I muffed anything.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Patch: Implement failover on libpq connect level.
Next
From: Tom Lane
Date:
Subject: Re: patch for geqo tweaks