Re: [BUGS] BUG #12989: pg_size_pretty with negative values - Mailing list pgsql-hackers

From Adrian Vondendriesch
Subject Re: [BUGS] BUG #12989: pg_size_pretty with negative values
Date
Msg-id 563CE704.1020104@credativ.de
Whole thread Raw
In response to Re: [BUGS] BUG #12989: pg_size_pretty with negative values  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [BUGS] BUG #12989: pg_size_pretty with negative values  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Am 06.11.2015 um 17:06 schrieb Robert Haas:
> On Thu, Nov 5, 2015 at 4:19 PM, Adrian.Vondendriesch
> <Adrian.Vondendriesch@credativ.de> wrote:
>> New patch attached and rebased on HEAD
>> (8c75ad436f75fc629b61f601ba884c8f9313c9af).
>
> I've committed this with some modifications:
>
> - I changed the comment for the half_rounded() macros because the one
> you had just restated the code.
> - I tightened up the coding in numeric_half_rounded() very slightly.
> - You didn't, as far as I can see, modify the regression test schedule
> to execute the files you added.  I consolidated them into one file,
> added it to the schedule, and tightened up the SQL a bit.

Looks much better now.

>
> Thanks for the patch, and please let me know if I muffed anything.

Thanks for reviewing and improving the changes.

I changed the status to committed.

Regards,- Adrian


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: extend pgbench expressions with functions
Next
From: Robert Haas
Date:
Subject: Re: [PATCH] Refactoring of LWLock tranches