Re: [HACKERS] Small improvement to parallel query docs - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Small improvement to parallel query docs
Date
Msg-id CA+Tgmoa+4c4Lz_a35RzuMxfO6ggiikVHA+dFSdMy=64-VLqLPQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Small improvement to parallel query docs  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: [HACKERS] Small improvement to parallel query docs  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
On Tue, Feb 14, 2017 at 5:17 AM, David Rowley
<david.rowley@2ndquadrant.com> wrote:
> On 14 February 2017 at 21:25, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> +    Aggregate</> stage. For such cases there is clearly going to be no
>> +    performance benefit to using parallel aggregation.
>>
>> A comma is required after "For such cases"
>
> Added
>
>>> The query planner takes
>>> +    this into account during the planning process and will choose how to
>>> +    perform the aggregation accordingly.
>>
>> This part of the sentence sounds unclear.   It doesn't clearly
>> indicate that planner won't choose a parallel plan in such cases.
>
> I thought that was obvious enough giving that I'd just mentioned that
> there's clearly no benefit, however I've changed things to make that a
> bit more explicit.
>
> Thanks for reviewing this.
>
> Updated patch attached.

Committed and back-patched to 9.6.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] removing tsearch2
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] UPDATE of partition key