Re: CustomScan support on readfuncs.c - Mailing list pgsql-hackers

From Robert Haas
Subject Re: CustomScan support on readfuncs.c
Date
Msg-id CA+TgmoZj_uTKfqk-kx9pXV9S+M0R=1+ifKQHCV-nj820oXtoyg@mail.gmail.com
Whole thread Raw
In response to Re: CustomScan support on readfuncs.c  (Kouhei Kaigai <kaigai@ak.jp.nec.com>)
Responses Re: CustomScan support on readfuncs.c
List pgsql-hackers
On Sat, Nov 7, 2015 at 6:38 AM, Kouhei Kaigai <kaigai@ak.jp.nec.com> wrote:
> Are you suggesting to pass the object name on software build time?

Yes.  That's what test_shm_mq and worker_spi already do:
       sprintf(worker.bgw_library_name, "test_shm_mq");

> If so, it may load incorrect libraries when DBA renamed its filename.
> At least, PostgreSQL cannot prevent DBA to rename library filenames
> even if they try to deploy "pg_strom.so", "pg_strom.20151106.so" and
> "pg_strom.20151030_bug.so" on same directory.

I agree.  But that's not a new problem that needs to be solved by this
patch.  It already exists - see above.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Erroneous cost estimation for nested loop join
Next
From: Robert Haas
Date:
Subject: Re: Extracting fields from 'infinity'::TIMESTAMP[TZ]