Re: pgsql: Make walsender more responsive. - Mailing list pgsql-committers

From Robert Haas
Subject Re: pgsql: Make walsender more responsive.
Date
Msg-id CA+TgmoZdPKrSWHfmLdkhzybMnc8nisfBrmac96d5uu8qUiT=0Q@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Make walsender more responsive.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Mon, Jul 2, 2012 at 11:06 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Mon, Jul 2, 2012 at 10:34 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> (I got a good laugh out of the idea of "contented locks".)
>
>> Uh... what?  I thought the meaning of that was perfectly clear.
>
> My dictionary defines "contented" as "happy and at ease".  I think
> the word intended here is "contended":

Oh, nuts.  My eyes skimmed right over that one after you pointed it out.

> +   /* wakeup the WalSnd now that we outside contented locks */
>
> not to mention that this sentence no verb.  I don't hold such things
> against patch submitters whose first language isn't English, but
> committers whose first language *is* English ought to fix them.

OK.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Make walsender more responsive.
Next
From: Robert Haas
Date:
Subject: pgsql: Work a little harder on comments for walsender wakeup patch.