Postgres Pro
Downloads
Home   >   mailing lists

Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property? - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property?
Date
Msg-id CA+TgmoZa3AVDK5WW2yRiD0VgmrrvEZPjMTrsRBb87XNNDTsxuw@mail.gmail.com
Whole thread Raw
In response to Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property?  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property?
List pgsql-hackers
Tree view 
On Mon, Apr 20, 2015 at 5:41 PM, Bruce Momjian <bruce@momjian.us> wrote:
> On Mon, Apr 20, 2015 at 05:04:14PM -0400, Robert Haas wrote:
>> On Mon, Apr 20, 2015 at 4:11 PM, Bruce Momjian <bruce@momjian.us> wrote:
>> > Slightly improved patch applied.
>>
>> Is it?
>
> The patch has a slightly modified 'if' statement to check a constant
> before calling a function, and use elseif:
>
>         < +     if (!interpretOidsOption(stmt->options, true) && cxt.hasoids)
>         ---
>         > +     if (cxt.hasoids && !interpretOidsOption(stmt->options, true))
>         47c57
>         < +     if (interpretOidsOption(stmt->options, true) && !cxt.hasoids)
>         ---
>         > +     else if (!cxt.hasoids && interpretOidsOption(stmt->options, true))
>
> I realize the change is subtle.

What I meant was - I didn't see an attachment on that message.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: Reducing spinlock acquisition within clock sweep loop
Next
From: Robert Haas
Date:
Subject: Re: Streaming replication and WAL archive interactions