Postgres Pro
Downloads
Home   >   mailing lists

Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property? - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property?
Date
Msg-id 20150420214116.GT11720@momjian.us
Whole thread Raw
In response to Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property?  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property?
List pgsql-hackers
Tree view 
On Mon, Apr 20, 2015 at 05:04:14PM -0400, Robert Haas wrote:
> On Mon, Apr 20, 2015 at 4:11 PM, Bruce Momjian <bruce@momjian.us> wrote:
> > Slightly improved patch applied.
> 
> Is it?

The patch has a slightly modified 'if' statement to check a constant
before calling a function, and use elseif:
< +     if (!interpretOidsOption(stmt->options, true) && cxt.hasoids)---> +     if (cxt.hasoids &&
!interpretOidsOption(stmt->options,true))47c57< +     if (interpretOidsOption(stmt->options, true) && !cxt.hasoids)--->
+    else if (!cxt.hasoids && interpretOidsOption(stmt->options, true))
 

I realize the change is subtle.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Clock sweep not caching enough B-Tree leaf pages?
Next
From: Bruce Momjian
Date:
Subject: Re: Turning off HOT/Cleanup sometimes