Re: [PATCH] Log crashed backend's query (activity string) - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [PATCH] Log crashed backend's query (activity string)
Date
Msg-id CA+TgmoZHpu5nixc3i7J9M-_V+0FDcXbF4DMnrU9u7QEu4dZxxw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Log crashed backend's query (activity string)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Sep 7, 2011 at 4:00 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
>> Excerpts from Robert Haas's message of mar sep 06 19:57:07 -0300 2011:
>>> TBH, I'm very unclear what could cause the postmaster to go belly-up
>>> copying a bounded amount of data out of shared memory for logging
>>> purposes only.  It's surely possible to make the code safe against any
>>> sequence of bytes that might be found there.
>
>> A mishandled encoding conversion could be problematic, so that needs to
>> be carefully considered (perhaps just shut off unconditionally).
>
> That, and the question of exactly what makes the amount bounded, and

The fact that it's a fixed-size chunk of shmem.  We won't copy more
bytes than the size of the buffer.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Large C files
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Log crashed backend's query (activity string)