Re: [PATCH] Log crashed backend's query (activity string) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Log crashed backend's query (activity string)
Date
Msg-id 836.1315425644@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Log crashed backend's query (activity string)  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: [PATCH] Log crashed backend's query (activity string)
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Excerpts from Robert Haas's message of mar sep 06 19:57:07 -0300 2011:
>> TBH, I'm very unclear what could cause the postmaster to go belly-up
>> copying a bounded amount of data out of shared memory for logging
>> purposes only.  It's surely possible to make the code safe against any
>> sequence of bytes that might be found there.

> A mishandled encoding conversion could be problematic, so that needs to
> be carefully considered (perhaps just shut off unconditionally).

That, and the question of exactly what makes the amount bounded, and
probably six other things that could go wrong.  But I'm sure Andrew
won't be pleased with a proposal to inject unknown-encoding data into
the logs.

I remain of the opinion that this needs to be kept out of the postmaster.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: problem of win32.mak
Next
From: Robert Haas
Date:
Subject: Re: [PATCH] Log crashed backend's query (activity string)