Re: strange error reporting - Mailing list pgsql-hackers

From Robert Haas
Subject Re: strange error reporting
Date
Msg-id CA+TgmoZ2N+tWm_xMboSQnpUbgrV6fCVu8_TEYBWY2fhdnMqX4g@mail.gmail.com
Whole thread Raw
In response to Re: strange error reporting  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: strange error reporting  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On Wed, Jan 20, 2021 at 1:54 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > On 2021-Jan-20, Robert Haas wrote:
> >> I figured it was something like that. I don't know whether the right
> >> thing is to use something like PQdb() to get the correct database
> >> name, or whether we should go with Tom's suggestion and omit that
> >> detail altogether, but I think showing the empty string when the user
> >> relied on the default is too confusing.
>
> > Well, the patch seems small enough, and I don't think it'll be in any
> > way helpful to omit that detail.
>
> I'm +1 for applying and back-patching that.  I still think we might
> want to just drop the phrase altogether in HEAD, but we wouldn't do
> that in the back branches, and the message is surely misleading as-is.

Sure, that makes sense.

-- 
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Calculation of relids (pull_varnos result) for PlaceHolderVars
Next
From: Tom Lane
Date:
Subject: Re: poc - possibility to write window function in PL languages