Re: parallel dump/restore code on WIndows - Mailing list pgsql-hackers

From Robert Haas
Subject Re: parallel dump/restore code on WIndows
Date
Msg-id CA+TgmoYmgN38oCUF-D9XAzSuGmNBkmTMoLF_cQK27fqGYVevvw@mail.gmail.com
Whole thread Raw
In response to parallel dump/restore code on WIndows  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On Thu, Apr 5, 2012 at 8:12 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
> Why was this code:
>
>   #ifdef WIN32
>       if (parallel_init_done && GetCurrentThreadId() != mainThreadId)
>           ExitThread(code);
>   #endif
>
>
> removed from dumputils.c by commit 5e86c61a7eec0fdc6961493a150159fa8fc63b1c?
> The commit message doesn't refer to it at all.
>
> I don't understand it at all, and there is nothing in Joachim's latest patch
> that would call ExitThread() from an exit handler, so the effect seems
> likely to me to break parallel windows processing in nasty ways if called
> from a worker thread, although I haven't tested it.

Ah, snap.  That's a mistake on my part.  Sorry.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: "iihero"
Date:
Subject: About the behavior of array_length() for empty array
Next
From: Shigeru HANADA
Date:
Subject: Re: WIP: Collecting statistics on CSV file data