Re: [HACKERS] Should logtape.c blocks be of type long? - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Should logtape.c blocks be of type long?
Date
Msg-id CA+TgmoYc59qwrAiQYsRw5cVeVo+MgK4Mp8q7V-n8HXfd+BL=_A@mail.gmail.com
Whole thread Raw
In response to [HACKERS] Should logtape.c blocks be of type long?  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
On Sun, Feb 26, 2017 at 2:44 AM, Peter Geoghegan <pg@bowt.ie> wrote:
> I tend to be suspicious of use of the type "long" in general, because
> in general one should assume that it is no wider than "int". This
> calls into question why any code that uses "long" didn't just use
> "int", at least in my mind.

Yeah.  Using things that are guaranteed to be the size we want them to
be (and the same size on all platforms) seems like a good plan.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Proposal for changes to recovery.conf API
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Automatic cleanup of oldest WAL segments with pg_receivexlog