Re: [HACKERS] Speedup twophase transactions - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Speedup twophase transactions
Date
Msg-id CA+TgmoYXFszejwyMDOVEcvVTKvzQG7HvrHmzOA6cdmPDT7Z7Kg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Speedup twophase transactions  (Nikhil Sontakke <nikhils@2ndquadrant.com>)
Responses Re: [HACKERS] Speedup twophase transactions  (Nikhil Sontakke <nikhils@2ndquadrant.com>)
List pgsql-hackers
On Mon, Jan 23, 2017 at 7:00 AM, Nikhil Sontakke
<nikhils@2ndquadrant.com> wrote:
> 4) Minor nit-pick on existing code.
>
> (errmsg_plural("%u two-phase state file was written "
>                                                           "for
> long-running prepared transactions",
>                                                           "%u
> two-phase state files were written "
>                                                           "for
> long-running prepared transactions",
>                                                           serialized_xacts,
>                                                           serialized_xacts)
>
> Shouldn’t the singular part of the message above be:
> "%u two-phase state file was written for a long-running prepared transaction"
>
> But, then, English is not my native language, so I might be off here :-)

If there's one file per long-running prepared transaction, which I
think is true, then I agree with you.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Re: [HACKERS] COPY as a set returning function
Next
From: Emre Hasegeli
Date:
Subject: Re: [HACKERS] Floating point comparison inconsistencies of thegeometric types