Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication
Date
Msg-id CA+TgmoYF-jf59+pFAdWezEi7+pEC5xns2_dUngR6ye6NJ9KDnw@mail.gmail.com
Whole thread Raw
In response to Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication  (Christian Kruse <christian@2ndquadrant.com>)
Responses Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
On Fri, Feb 7, 2014 at 4:34 AM, Christian Kruse
<christian@2ndquadrant.com> wrote:
> attached you will find a new version with the following issues
> resolved:
>
> - use backend ID once again for getting the xid and xmin
> - use <xref> instead of <link> in documentation
> - rename fields to backend_xid and backend_xmin

This looks mostly good but it doesn't address this point, from one of
my earlier emails:

If I understand correctly, modifying PgBackendStatus adds additional
fields to the shared memory data structure that are never used and
will be returned by functions like pgstat_fetch_stat_beentry()
unitialized.  That seems both inefficient and a pitfall for the
unwary.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Memory ordering issue in LWLockRelease, WakeupWaiters, WALInsertSlotRelease
Next
From: Amit Kapila
Date:
Subject: Re: narwhal and PGDLLIMPORT