tableam: inconsistent parameter name - Mailing list pgsql-hackers

From Robert Haas
Subject tableam: inconsistent parameter name
Date
Msg-id CA+TgmoY49ManQWnJtiwkuytXBkmyTuDFqb74Pr4Zn2Nq9TuNBQ@mail.gmail.com
Whole thread Raw
Responses Re: tableam: inconsistent parameter name
List pgsql-hackers
TableAmRoutine's index_build_range_scan thinks that parameter #8 is
called end_blockno, but table_index_build_range_scan and
heapam_index_build_range_scan and BRIN's summarize_range all agree
that it's the number of blocks to be scanned.  I assume that this got
changed at some point while Andres was hacking on it and this one
place just never got updated.

Proposed patch attached.  Since this seems like a bug, albeit a
harmless one, I propose to commit this to v12.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: tableam: abstracting relation sizing code
Next
From: Andres Freund
Date:
Subject: Re: Custom table AMs need to include heapam.h because ofBulkInsertState