Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool
Date
Msg-id CA+OCxozdyiLFVv2XV1RtpYzN+vryzgDK-nY8cu_xz1J=t8vuGA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool
List pgadmin-hackers
Hi

On Mon, Sep 18, 2017 at 2:20 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

Please disregard my previous patch and instead attaching updated patch.

In my previous patch I used `let` keyword instead of `var` for defining variable, for consistency & backward compatibility I have used `var` in my latest patch.

That seems like an odd way to fix this - we put in ***** Error ***** in the backend, then remove it in the front end.

I think it would be better to ensure it's formatted sensibly at the backed to begin with. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Fix for Exception when the server is restarted [RM2713][pgAdmin4]
Next
From: Murtuza Zabuawala
Date:
Subject: Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool