Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool - Mailing list pgadmin-hackers

Hi Dave,

PFA patch.

On Mon, Sep 18, 2017 at 4:34 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Mon, Sep 18, 2017 at 10:54 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

PFA minor patch to fix the issue where logic to extract the error using RegEX from error message was incorrect in Query tool(History tab).

RM#2700

Thanks - applied, but....

- Could you please add some JS tests to ensure parseErrorMessage continues to work as it should.

​Done​

 

- I'm not happy with the fact that we still display:

can't execute an empty query ********** Error **********

Can we not make that look more like a real error message? At the very least something like:

Error: can't execute an empty query

​Done​

 

 

Another minor issue which I observed on login page is that close button on alert is little misaligned(screenshot attached).

Also applied - thanks! 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company