Re: [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4] - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]
Date
Msg-id CA+OCxoyXX20oEJVL3-Rf=Zt0=rrYyftden0LX5K2+8mcL_Tj=g@mail.gmail.com
Whole thread Raw
In response to [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
Responses Re: [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
List pgadmin-hackers
Hi

On Fri, Mar 17, 2017 at 7:02 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> Here is patch for RM2243 and RM2244
>
> Changes: 1. Pickup correct encoding in qtLiteral to decode.
> 2. While releasing database connection only decode database name if it's not
> unicode.

This fixes 2243, but 2244 is an SQL error that occurs when querying
tables with no columns in the Query Tool. Although Fahar found it
whilst testing with an Arabic name, it's otherwise unrelated.

Patch committed to fix 2243 only.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: [pgadmin-hackers] pgAdmin 4 commit: Fix dropping of databases with Unicode names. Fixes#
Next
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move languageselection to Preferences.