Re: PATCH: to fix jsonb type rendering in runtime (pgAdmin4) - Mailing list pgadmin-hackers

From Dave Page
Subject Re: PATCH: to fix jsonb type rendering in runtime (pgAdmin4)
Date
Msg-id CA+OCxoy7YgxiH6rOeUOhPmUvx9hgvOWXhxYzhbHVbHx_5mBtTQ@mail.gmail.com
Whole thread Raw
In response to PATCH: to fix jsonb type rendering in runtime (pgAdmin4)  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: PATCH: to fix jsonb type rendering in runtime (pgAdmin4)  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers
Hi

On Wed, Jun 29, 2016 at 10:32 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue of jsonb type rendering issue in runtime.
> RM#1404

I'm not convinced this is a good fix for a couple of reasons:

1) You're only applying the fix if we're running in the runtime. The
runtime uses the Webkit engine just as Safari and Chrome do, so I'm
more inclined to believe this is a version specific issue, rather than
something that is definitely confined to the runtime.

2) What if the user has JSON data in a json field? Or worse, a text field?

I wonder if we could/should mark the contents of all text fields as
CDATA to prevent the browser trying to do anything with them.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: Re: PATCH: Fix the issue for saving query output as CSV
Next
From: Dave Page
Date:
Subject: Re: PATCH: Fix the issue for saving query output as CSV