Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1730 - Role membershipcontrol display needs improvement - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1730 - Role membershipcontrol display needs improvement
Date
Msg-id CA+OCxoxa9MtPM9Jmc=ESKpE_4cTWonMi0=uODhzg1pcjfa_o9w@mail.gmail.com
Whole thread Raw
In response to [pgadmin-hackers] [pgAdmin4][Patch]: RM 1730 - Role membership control display needs improvement  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1730 - Role membershipcontrol display needs improvement  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi

On Friday, January 6, 2017, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix RM 1730 - Role membership control display needs improvement

Fixed items:

- An alternate note is needed when shown on the properties panel
- Remove the border
- Align the label and control in columns as per other controls.

Remaining: 

- Investigate making the control multi-line.
   - The control already implemented in a way that, once the selected options don't fit in a single line, it becomes multi-line.

That should be fine then I think.

The rest looks good, except:

- If there are no roles listed, it still has a hint of "Select members" in the properties panel.

- If there are roles listed, there's a non-functional but clickable x at the end of the control.

Can you look at those issues please?

Thanks! 


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers] pgAdmin IV: Minor code changes in API test cases
Next
From: Dave Page
Date:
Subject: [pgadmin-hackers] pgAdmin 4 commit: Ensure breakpoints are cleared properly whenclearing