Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1730 - Role membershipcontrol display needs improvement - Mailing list pgadmin-hackers

Hi

On Friday, January 6, 2017, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached patch to fix RM 1730 - Role membership control display needs improvement

Fixed items:

- An alternate note is needed when shown on the properties panel

- Remove the border

- Align the label and control in columns as per other controls.

Remaining: 

- Investigate making the control multi-line.

   - The control already implemented in a way that, once the selected options don't fit in a single line, it becomes multi-line.

That should be fine then I think.

The rest looks good, except:

- If there are no roles listed, it still has a hint of "Select members" in the properties panel.

- If there are roles listed, there's a non-functional but clickable x at the end of the control.

Can you look at those issues please?

Thanks! 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company