Re: Download navigation UX - Mailing list pgsql-www

From Dave Page
Subject Re: Download navigation UX
Date
Msg-id CA+OCxowm0s9=HLoo-h=SuYiosAJCHeRib0ves=2kQcO+p=dcmw@mail.gmail.com
Whole thread Raw
In response to Re: Download navigation UX  ("Jonathan S. Katz" <jkatz@postgresql.org>)
Responses Re: Download navigation UX  ("Jonathan S. Katz" <jkatz@postgresql.org>)
Re: Download navigation UX  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-www


On Tue, Jul 7, 2020 at 2:15 PM Jonathan S. Katz <jkatz@postgresql.org> wrote:
On 7/7/20 6:02 AM, Dave Page wrote:
> Here's an updated patch (based on Jonathan's update) which combines the
> inline handler patch and removes the inline handlers from the main patch.

Looking good. One comment:

Given there's nothing dynamic about serving the new apt.js /
download.js, we don't need to serve those dynamically from the Django
app. We can just plop them into "/media/js", e.g.
"/media/js/download.js" and then this becomes:

<script type="text/javascript"
src="/media/js/download.js?{{gitrev}}"></script>

Thanks - committed with that change.
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-www by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Download navigation UX
Next
From: "Jonathan S. Katz"
Date:
Subject: Re: Download navigation UX