Re: Download navigation UX - Mailing list pgsql-www

From Jonathan S. Katz
Subject Re: Download navigation UX
Date
Msg-id d5d262d5-6e19-e49a-e0bc-bffd76e8f41a@postgresql.org
Whole thread Raw
In response to Re: Download navigation UX  (Dave Page <dpage@pgadmin.org>)
Responses Re: Download navigation UX
List pgsql-www
On 7/7/20 11:53 AM, Dave Page wrote:
>
>
> On Tue, Jul 7, 2020 at 2:15 PM Jonathan S. Katz <jkatz@postgresql.org
> <mailto:jkatz@postgresql.org>> wrote:
>
>     On 7/7/20 6:02 AM, Dave Page wrote:
>     > Here's an updated patch (based on Jonathan's update) which
>     combines the
>     > inline handler patch and removes the inline handlers from the main
>     patch.
>
>     Looking good. One comment:
>
>     Given there's nothing dynamic about serving the new apt.js /
>     download.js, we don't need to serve those dynamically from the Django
>     app. We can just plop them into "/media/js", e.g.
>     "/media/js/download.js" and then this becomes:
>
>     <script type="text/javascript"
>     src="/media/js/download.js?{{gitrev}}"></script>
>
>
> Thanks - committed with that change.

Awesome, thanks!

Jonathan


Attachment

pgsql-www by date:

Previous
From: Dave Page
Date:
Subject: Re: Download navigation UX
Next
From: Magnus Hagander
Date:
Subject: Re: Download navigation UX