Re: Patch: Auto-generate search_path statement for selected schema in query editor - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Patch: Auto-generate search_path statement for selected schema in query editor
Date
Msg-id CA+OCxowZx1sfcXhv5TQjFbpHfXDPgPvcne1mbhdf=oQqPr2t-w@mail.gmail.com
Whole thread Raw
In response to Re: Patch: Auto-generate search_path statement for selected schema in query editor  (Neel Patel <neel.patel@enterprisedb.com>)
Responses Re: Patch: Auto-generate search_path statement for selected schema in query editor  (Neel Patel <neel.patel@enterprisedb.com>)
List pgadmin-hackers
Hi


On Mon, Mar 18, 2013 at 1:09 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi,

We have checked the bug and below is our finding.

As we are getting the pane information from the manager and pane could not be found in the manager so at that time wxAuiPaneInfo structure is not valid and when we call Update() then it was crashing. So before calling to Update() we put check for validating the wxAuxPaneInfo structure as below.

wxAuiPaneInfo outputPaneInfo = manager.GetPane(wxT("outputPane")).Show(false);

wxAuiPaneInfo scratchPad = manager.GetPane(wxT("scratchPad")).Show(false);

viewMenu->Enable(MNU_OUTPUTPANE, false);

viewMenu->Enable(MNU_SCRATCHPAD, false);

if (outputPaneInfo.IsOk() == true && scratchPad.IsOk() == true)

    manager.Update();


Please find the patch along with this email and let me know.

It still crashes for me I'm afraid. Testing on Windows, debug build, VC++ 2010. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: Re: Patch: Auto-generate search_path statement for selected schema in query editor
Next
From: Guillaume Lelarge
Date:
Subject: pgAdmin III commit: Add tab option in the Import dialog