Re: pg_trigger.tgparentid - Mailing list pgsql-hackers

From Amit Langote
Subject Re: pg_trigger.tgparentid
Date
Msg-id CA+HiwqFhk_jBAd6rqBY45LZBbTOhNaZg-7PHWeqZF7DCKSPd7w@mail.gmail.com
Whole thread Raw
In response to Re: pg_trigger.tgparentid  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: pg_trigger.tgparentid
List pgsql-hackers
On Tue, Feb 25, 2020 at 11:01 PM Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> On 2020-Feb-25, Amit Langote wrote:
> > On Tue, Feb 25, 2020 at 3:58 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > > Thanks for pointing this out -- I agree it needed rewording.  I slightly
> > > adjusted your text like this:
> > >
> > >                  * Internal triggers require careful examination.  Ideally, we don't
> > >                  * clone them.  However, if our parent is itself a partition, there
> > >                  * might be internal triggers that must not be skipped; for example,
> > >                  * triggers on our parent that are in turn clones from its parent (our
> > >                  * grandparent) are marked internal, yet they are to be cloned.
> > >
> > > Is this okay for you?
> >
> > Thanks.  Your revised text looks good, except there is a typo:
> >
> > in turn clones -> in turn cloned
>
> Actually, that was on purpose ...  (I also changed "were" to "are" to match.)

Ah, got it.

Thanks,
Amit



pgsql-hackers by date:

Previous
From: Asif Rehman
Date:
Subject: Re: [Patch] Base backups and random or zero pageheaders
Next
From: tushar
Date:
Subject: Re: [Proposal] Global temporary tables