Re: [PATCH] Do not use StdRdOptions in Access Methods - Mailing list pgsql-hackers

On Thu, Nov 7, 2019 at 10:54 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Thu, Nov 07, 2019 at 10:49:38AM +0900, Amit Langote wrote:
> > I looked around but don't understand why these macros need to be
> > exposed.  I read this comment:
> >
> >  *  Note that this is more or less the same that fillRelOptions does, so only
> >  *  use this if you need to do something non-standard within some option's
> >  *  code block.
> >
> > but don't see how an AM author might be able to do something
> > non-standard with this interface.
> >
> > Maybe Alvaro knows this better.
>
> Perhaps there is a point in cleaning up all that more, but I am not
> sure that it is worth potentially breaking other people's code.

Sure.  Maybe, we could add a deprecation note for these more
fine-grained APIs like my first patch did.

+/*
+ * Using parseRelOptions(), allocateReloptStruct(), and fillRelOptions()
+ * directly is Deprecated; use build_reloptions() instead.
+ */

Thanks,
Amit