Re: [PATCH] Do not use StdRdOptions in Access Methods - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Do not use StdRdOptions in Access Methods
Date
Msg-id 20191107015429.GB1768@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Do not use StdRdOptions in Access Methods  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: [PATCH] Do not use StdRdOptions in Access Methods  (Amit Langote <amitlangote09@gmail.com>)
List pgsql-hackers
On Thu, Nov 07, 2019 at 10:49:38AM +0900, Amit Langote wrote:
> I looked around but don't understand why these macros need to be
> exposed.  I read this comment:
>
>  *  Note that this is more or less the same that fillRelOptions does, so only
>  *  use this if you need to do something non-standard within some option's
>  *  code block.
>
> but don't see how an AM author might be able to do something
> non-standard with this interface.
>
> Maybe Alvaro knows this better.

Perhaps there is a point in cleaning up all that more, but I am not
sure that it is worth potentially breaking other people's code.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [PATCH] Do not use StdRdOptions in Access Methods
Next
From: Amit Langote
Date:
Subject: Re: [PATCH] Do not use StdRdOptions in Access Methods