Re: Reserve prefixes for loaded libraries proposal - Mailing list pgsql-hackers

From Florin Irion
Subject Re: Reserve prefixes for loaded libraries proposal
Date
Msg-id CA+HEvJCRTdPohjSVExoW_-u7v_jwrLYEiEZ5H_E1mNq4N6wxvQ@mail.gmail.com
Whole thread Raw
In response to Re: Reserve prefixes for loaded libraries proposal  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
Committed.

I made two notable changes:  I renamed the function, since it looked
like EmitWarningsOnPlaceholders() but was doing something not analogous. 
  Also, you had in your function

     strncmp(varName, var->name, varLen)

probably copied from EmitWarningsOnPlaceholders(), but unlike there, we
want to compare the whole string here, and this would potentially do
something wrong if there were a GUC setting that was a substring of the
name of another one.

Yeah, it makes sense! 
 
Thank you very much!
Thank you for the changes and thank you for committing it!

Cheers,
Florin


--
Florin Irion
Cel: +39 328 5904901
Tel: +39 0574 054953
Via Alvise Cadamosto, 47
59100, Prato, PO
Italia

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Correct handling of blank/commented lines in PSQL interactive-mode history
Next
From: Kenaniah Cerny
Date:
Subject: Re: Proposal: allow database-specific role memberships