Re: Reserve prefixes for loaded libraries proposal - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Reserve prefixes for loaded libraries proposal
Date
Msg-id 5cae3907-e396-c72f-e69a-1d2950585755@enterprisedb.com
Whole thread Raw
In response to Re: Reserve prefixes for loaded libraries proposal  (Florin Irion <irionr@gmail.com>)
Responses Re: Reserve prefixes for loaded libraries proposal
List pgsql-hackers
On 07.10.21 14:03, Florin Irion wrote:
> I adjusted a bit the code and configured my mail client to
> send patch attachments appropiately(hopefully). :)
> 
> So here is my second version.

Committed.

I made two notable changes:  I renamed the function, since it looked 
like EmitWarningsOnPlaceholders() but was doing something not analogous. 
  Also, you had in your function

     strncmp(varName, var->name, varLen)

probably copied from EmitWarningsOnPlaceholders(), but unlike there, we 
want to compare the whole string here, and this would potentially do 
something wrong if there were a GUC setting that was a substring of the 
name of another one.




pgsql-hackers by date:

Previous
From: Matthias van de Meent
Date:
Subject: Re: [PATCH] Partial foreign key updates in referential integrity triggers
Next
From: Andrew Dunstan
Date:
Subject: Re: SQL/JSON: functions