Postgres Pro
Downloads
Home   >   mailing lists

Re: PostgreSQL Service on Windows does not start. ~ "is not a valid Win32 application" - Mailing list pgsql-hackers

From Rajeev rastogi
Subject Re: PostgreSQL Service on Windows does not start. ~ "is not a valid Win32 application"
Date
Msg-id BF2827DCCE55594C8D7A8F7FFD3AB7713DDAC41E@SZXEML508-MBX.china.huawei.com
Whole thread Raw
In response to Re: PostgreSQL Service on Windows does not start. ~ "is not a valid Win32 application"  (Naoya Anzai <anzai-naoya@mxu.nes.nec.co.jp>)
Responses Re: PostgreSQL Service on Windows does not start. ~ "is not a valid Win32 application"  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
ON 11 November 2013, Naoya Anzai Wrote:

>>
>> Hi Amit,
>>
> > I have uploaded your patch for next commit fest, hope you can support
> > it if there is any feedback for your patch by reviewer/committer.
> Thanks! Okay, I will support you.

1. Patch applies cleanly to master HEAD.
2. No Compilation Warning.
3. It works as per the patch expectation.

One suggestion:
Instead of using sizeof(cmdLine),a. Can't we use strlen  (hence small 'for' loop).b. Or use memmove to move one byte.

Thanks and Regards,
Kumar Rajeev Rastogi

pgsql-hackers by date:

Previous
From: Rajeev rastogi
Date:
Subject: Re: COPY table FROM STDIN doesn't show count tag
Next
From: Rajeev rastogi
Date:
Subject: Re: Add min and max execute statement time in pg_stat_statement