Duplicated assignment of slot_name in walsender.c - Mailing list pgsql-hackers

From Bernd Helmle
Subject Duplicated assignment of slot_name in walsender.c
Date
Msg-id BE2FD71DEA35A2287EA5F018@eje.credativ.lan
Whole thread Raw
Responses Re: Duplicated assignment of slot_name in walsender.c  (Euler Taveira <euler@timbira.com.br>)
List pgsql-hackers
walsender.c, CreateReplicationSlot() currently has this:
       slot_name = NameStr(MyReplicationSlot->data.name);
       if (cmd->kind == REPLICATION_KIND_LOGICAL)       {[...]       }       else if (cmd->kind ==
REPLICATION_KIND_PHYSICAL&& cmd->reserve_wal)       {[...]       }
 
       slot_name = NameStr(MyReplicationSlot->data.name);

The 2nd assignment to slot_name looks unnecessary?

-- 
Thanks
Bernd



pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: PoC: Partial sort
Next
From: Etsuro Fujita
Date:
Subject: Typos in plannodes.h