Re: adding a new column in IDENTIFY_SYSTEM - Mailing list pgsql-hackers

From Jaime Casanova
Subject Re: adding a new column in IDENTIFY_SYSTEM
Date
Msg-id BANLkTinyBfKXyiHoB4nBd007Nyr6e9qasA@mail.gmail.com
Whole thread Raw
In response to Re: adding a new column in IDENTIFY_SYSTEM  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: adding a new column in IDENTIFY_SYSTEM  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On Tue, May 24, 2011 at 8:52 PM, Fujii Masao <masao.fujii@gmail.com> wrote:

> +       primary_xlp_magic = atoi(PQgetvalue(res, 0, 2));
>
> You wrongly get the third field (i.e., current xlog location) as the
> WAL version.
> You should call PQgetvalue(res, 0, 3), instead.
>
>> errdetail("Expected 1 tuple with 3 fields, got %d tuples with %d fields.",
>
> You need to change the above message.
>

Fixed.

About you comments on the check... if you read the thread, you will
find that the whole reason for the field is future improvement, but
everyone wanted some use of the field now... so i made a patch to use
it in pg_basebackup before the transfer starts and avoid time and
bandwith waste but Magnus prefer this in walreceiver...

--
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte y capacitación de PostgreSQL

Attachment

pgsql-hackers by date:

Previous
From: Greg Smith
Date:
Subject: Re: 9.2 schedule
Next
From: Josh Kupershmidt
Date:
Subject: Re: patch: Allow \dd to show constraint comments