Re: Foreign table permissions and cloning - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Foreign table permissions and cloning
Date
Msg-id BANLkTinS0Z4zAGgkNiTO0EgbKW7hMr9kJA@mail.gmail.com
Whole thread Raw
In response to Re: Foreign table permissions and cloning  (Shigeru Hanada <hanada@metrosystems.co.jp>)
List pgsql-hackers
2011/5/11 Shigeru Hanada <hanada@metrosystems.co.jp>:
> (2011/04/26 5:42), Robert Haas wrote:
>> OK.  Turned out a little more cleanup was needed to make this all the
>> way consistent with how we handle views; I have now done that.
>
> I noticed that some fixes would be needed for consistency about foreign
> table privileges. Attached patch includes fixes below:
>
> 1) psql doesn't complete FOREIGN TABLE after GRANT/REVOKE.
> 2) pg_dump uses GRANT .. ON TABLE for foreign tables, instead of ON
> FOREIGN TABLE.
> 3) GRANT document mentions that ALL TABLES includes foreign tables too.
> 4) Rows of information_schema.foreign_tables/foreign_table_options are
> visible to users who have any privileges on the foreign table.

Thanks; I'm embarrassed I didn't notice those things myself.  I've
committed this patch with very slight adjustment.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: hint bit cache v6
Next
From: Noah Misch
Date:
Subject: Reducing overhead of frequent table locks