Re: [Patch] Checksums for SLRU files - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: [Patch] Checksums for SLRU files
Date
Msg-id B8F85F94-ECB0-484E-96B8-21D928C8E711@yandex-team.ru
Whole thread Raw
In response to Re: [Patch] Checksums for SLRU files  (Andrey Borodin <x4mmm@yandex-team.ru>)
Responses Re: [Patch] Checksums for SLRU files  (Andrey Borodin <x4mmm@yandex-team.ru>)
List pgsql-hackers
Hi, Ivan!

> 5 марта 2018 г., в 20:58, Andrey Borodin <x4mmm@yandex-team.ru> написал(а):
>
> I've found that there are few more places with SLRU items per page

I was looking into this patch mainly because I was reviewing other checksums patch in different thread. But the purpose
ofthis patch seems viable for me. 
After looking into the patch I'd like to propose some editorialization:
0. Removed GUC: ignore_checksum_failure looks good enough
1. Removed copy on read from disk. Also I do not see a reason to copy page before write
2. multis are upgraded by WAL reset, CLOG is actually upgraded
3. Updated all places where SLRU block size was used


Best regards, Andrey Borodin.

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [HACKERS] path toward faster partition pruning
Next
From: David Rowley
Date:
Subject: Re: [HACKERS] path toward faster partition pruning