Re: [PATCH] Enable SSL library detection via PQsslAttribute - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [PATCH] Enable SSL library detection via PQsslAttribute
Date
Msg-id B0A2E221-C7C9-4C4B-9705-C7B986D9E6B0@yesql.se
Whole thread Raw
In response to Re: [PATCH] Enable SSL library detection via PQsslAttribute  (Jacob Champion <pchampion@vmware.com>)
Responses Re: [PATCH] Enable SSL library detection via PQsslAttribute
List pgsql-hackers
> On 25 Mar 2022, at 23:45, Jacob Champion <pchampion@vmware.com> wrote:
>
> On Fri, 2022-03-25 at 18:00 -0400, Tom Lane wrote:
>> Jacob Champion <pchampion@vmware.com> writes:
>>> Do I need to merge my tiny test program into the libpq_pipeline tests?
>>
>> Doesn't seem worth the trouble to me, notably because you'd
>> then have to cope with non-SSL builds too.
>
> Fine by me.
>
> v5 moves the docs out of the Note, as requested by Daniel.

I went over this again and I think this version is ready for committer.  Having
tried to add implement a new TLS library I would add a small comment on
PQsslAttributeNames() for this, reverse-engineering what to implement is hard
as it is without special cases easily identifiable.  That can easily be done
when pushed, no need for a new version IMHO.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Phil Krylov
Date:
Subject: Re: jsonpath syntax extensions
Next
From: Tom Lane
Date:
Subject: Re: refactoring basebackup.c (zstd workers)