Postgres Pro
Downloads
Home   >   mailing lists

Re: refactoring basebackup.c (zstd workers) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: refactoring basebackup.c (zstd workers)
Date
Msg-id 939442.1648499927@sss.pgh.pa.us
Whole thread Raw
In response to Re: refactoring basebackup.c (zstd workers)  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view 
Robert Haas <robertmhaas@gmail.com> writes:
> On Sun, Mar 27, 2022 at 1:47 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Not sure if you should remove this null-check or add some other ones,
>> but I think you ought to do one or the other.

> As I hope is apparent, the first hunk of this patch is not for commit,
> and the second hunk is for commit.

Looks plausible to me.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: [PATCH] Enable SSL library detection via PQsslAttribute
Next
From: Justin Pryzby
Date:
Subject: Re: refactoring basebackup.c (zstd workers)