Re: please update ps display for recovery checkpoint - Mailing list pgsql-hackers

From Bossart, Nathan
Subject Re: please update ps display for recovery checkpoint
Date
Msg-id B08B7934-A7DA-4A4E-BBFC-3505667F2B7E@amazon.com
Whole thread Raw
In response to Re: please update ps display for recovery checkpoint  (Michael Paquier <michael@paquier.xyz>)
Responses Re: please update ps display for recovery checkpoint
List pgsql-hackers
On 12/11/20, 4:00 PM, "Michael Paquier" <michael@paquier.xyz> wrote:
> On Fri, Dec 11, 2020 at 06:54:42PM +0000, Bossart, Nathan wrote:
>> This approach seems reasonable to me.  I've attached my take on it.
>
> +       /* Reset the process title */
> +       set_ps_display("");
> I would still recommend to avoid calling set_ps_display() if there is
> no need to so as we avoid useless system calls, so I think that this
> stuff had better use a common path for the set and reset logic.
>
> My counter-proposal is like the attached, with the set/reset part not
> reversed this time, and the code indented :p

Haha.  LGTM.

Nathan


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: please update ps display for recovery checkpoint
Next
From: Tom Lane
Date:
Subject: Re: Rethinking plpgsql's assignment implementation