Re: please update ps display for recovery checkpoint - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: please update ps display for recovery checkpoint
Date
Msg-id X9QH9ztwiVt1Lk/N@paquier.xyz
Whole thread Raw
In response to Re: please update ps display for recovery checkpoint  ("Bossart, Nathan" <bossartn@amazon.com>)
Responses Re: please update ps display for recovery checkpoint
List pgsql-hackers
On Fri, Dec 11, 2020 at 06:54:42PM +0000, Bossart, Nathan wrote:
> This approach seems reasonable to me.  I've attached my take on it.

+       /* Reset the process title */
+       set_ps_display("");
I would still recommend to avoid calling set_ps_display() if there is
no need to so as we avoid useless system calls, so I think that this
stuff had better use a common path for the set and reset logic.

My counter-proposal is like the attached, with the set/reset part not
reversed this time, and the code indented :p
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: pg_basebackup caused FailedAssertion
Next
From: "Bossart, Nathan"
Date:
Subject: Re: please update ps display for recovery checkpoint