Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages(). - Mailing list pgsql-committers

From Robert Haas
Subject Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().
Date
Msg-id AANLkTinudeEJcbZuXsA_t0y3OJ0R6vve9+NFbcOhsbsS@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Wed, Aug 25, 2010 at 11:46 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
> On Mon, 2010-08-16 at 02:02 +0000, Robert Haas wrote:
>> Log Message:
>> -----------
>> Make LockDatabaseObject() AcceptInvalidationMessages().
>>
>> This is appropriate for the same reasons we already do it in
>> LockSharedObject(): things might have changed while we were waiting
>> for the lock.  There doesn't seem to be a live bug here at the moment,
>> but that's mostly because it isn't currently used for very much.
>
> I have a horrible nagging feeling this breaks something. I remember
> noticing that about a year ago and it seemed to make sense then. Sorry,
> can't recall anything else at present.

Well, the only place it's used at the moment is in the drop-object
code.  Not sure if that might be enough to jog your memory?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

pgsql-committers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().
Next
From: petere@postgresql.org (Peter Eisentraut)
Date:
Subject: pgsql: Add missing description of reloftype field