Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages(). - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().
Date
Msg-id 1282751176.3865.1500.camel@ebony
Whole thread Raw
In response to pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().  (rhaas@postgresql.org (Robert Haas))
Responses Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
On Mon, 2010-08-16 at 02:02 +0000, Robert Haas wrote:
> Log Message:
> -----------
> Make LockDatabaseObject() AcceptInvalidationMessages().
>
> This is appropriate for the same reasons we already do it in
> LockSharedObject(): things might have changed while we were waiting
> for the lock.  There doesn't seem to be a live bug here at the moment,
> but that's mostly because it isn't currently used for very much.

I have a horrible nagging feeling this breaks something. I remember
noticing that about a year ago and it seemed to make sense then. Sorry,
can't recall anything else at present.

--
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Development, 24x7 Support, Training and Services


pgsql-committers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: pgsql: Correct sundry errors in Hot Standby-related comments.
Next
From: Robert Haas
Date:
Subject: Re: pgsql: Make LockDatabaseObject() AcceptInvalidationMessages().