Re: Review: Re: [PATCH] Re: Adding xpath_exists function - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Review: Re: [PATCH] Re: Adding xpath_exists function
Date
Msg-id AANLkTinqV-LqCN1dGjf6TdqgXiFQ3Sc-deWr7a8LRCBV@mail.gmail.com
Whole thread Raw
In response to Review: Re: [PATCH] Re: Adding xpath_exists function  (David Fetter <david@fetter.org>)
Responses Re: [RRR] Review: Re: [PATCH] Re: Adding xpath_exists function  (Jeff Davis <pgsql@j-davis.com>)
List pgsql-hackers
On Tue, Jul 27, 2010 at 7:33 PM, David Fetter <david@fetter.org> wrote:
>        Minor quibble with the regression tests: should we be using
>        dollar quotes in things like this?  Doubled-up quote marks:
>
>        SELECT xpath_exists('//town[text() =
''Cwmbran'']','<towns><town>Bidford-on-Avon</town><town>Cwmbran</town><town>Bristol</town></towns>'::xml);
>
>        Dollar quote:
>
>        SELECT xpath_exists($$//town[text() =
'Cwmbran']$$,'<towns><town>Bidford-on-Avon</town><town>Cwmbran</town><town>Bristol</town></towns>'::xml);

Personally, I don't really see that as an improvement.  Dollar-quotes
are really nice for longer strings, or where you would otherwise have
quadrupled quotes (or more), but I don't see a big advantage to it
here.  Still, it's a question of opinion more than anything else.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Parsing of aggregate ORDER BY clauses
Next
From: Robert Haas
Date:
Subject: Re: SSL cipher and version