Re: SQL/MED - file_fdw - Mailing list pgsql-hackers

From Itagaki Takahiro
Subject Re: SQL/MED - file_fdw
Date
Msg-id AANLkTinptuG1Jt=Rq6dsQ7eBTRgseoTXGzRAgd5XD-gT@mail.gmail.com
Whole thread Raw
In response to Re: SQL/MED - file_fdw  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: SQL/MED - file_fdw  (Andrew Dunstan <andrew@dunslane.net>)
Re: SQL/MED - file_fdw  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On Sun, Dec 5, 2010 at 07:24, Andrew Dunstan <andrew@dunslane.net> wrote:
> Looking at file_parser.c, it seems to be largely taken from copy.c. Wouldn't
> it be better to call those functions, or refactor them so they are callable
> if necessary?

We could export private functions and structs in copy.c,
though details of the implementation should be kept in copy.c.

How about splitting the file_fdw patch into two pieces?
One exports the copy functions from the core, and another
implements file_fdw using the infrastructure.

-- 
Itagaki Takahiro


pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: [PATCH] Revert default wal_sync_method to fdatasync on Linux 2.6.33+
Next
From: Greg Smith
Date:
Subject: Re: Re: Proposed Windows-specific change: Enable crash dumps (like core files)