On 12/04/2010 11:11 PM, Itagaki Takahiro wrote:
> On Sun, Dec 5, 2010 at 07:24, Andrew Dunstan<andrew@dunslane.net> wrote:
>> Looking at file_parser.c, it seems to be largely taken from copy.c. Wouldn't
>> it be better to call those functions, or refactor them so they are callable
>> if necessary?
> We could export private functions and structs in copy.c,
> though details of the implementation should be kept in copy.c.
>
> How about splitting the file_fdw patch into two pieces?
> One exports the copy functions from the core, and another
> implements file_fdw using the infrastructure.
>
Yes please.
cheers
andrew
