Re: WIP: extensible enums - Mailing list pgsql-hackers

From Robert Haas
Subject Re: WIP: extensible enums
Date
Msg-id AANLkTin3FXrSBcxLN+4F+LZ=Mo4o=cX-jwf4kdprYw4s@mail.gmail.com
Whole thread Raw
In response to Re: WIP: extensible enums  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: WIP: extensible enums
List pgsql-hackers
On Fri, Oct 1, 2010 at 7:12 AM, Andrew Dunstan <andrew@dunslane.net> wrote:
> On 10/01/2010 04:35 AM, Dean Rasheed wrote:
>>
>> 2). In enum_ccmp(), when you cache the full list of elements, you're
>> not updating mycache->sort_list_length, so it will keep fetching the
>> full list each time. Also, I think that function could use a few more
>> comments.
>
> Good catch. Will fix.
>
>> 3). I think you need to update psql so that \dT+ returns the enum
>> elements in the right order.
>
> Yeah. Will do.
>
> I will post a revised patch soon.

Should we postpone this to the next CommitFest?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: levenshtein_less_equal (was: multibyte charater set in levenshtein function)
Next
From: Robert Haas
Date:
Subject: Re: security hook on authorization