Re: WIP: extensible enums - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: WIP: extensible enums
Date
Msg-id 4CA5C218.4030006@dunslane.net
Whole thread Raw
In response to Re: WIP: extensible enums  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: WIP: extensible enums
List pgsql-hackers

On 10/01/2010 04:35 AM, Dean Rasheed wrote:
> 2). In enum_ccmp(), when you cache the full list of elements, you're
> not updating mycache->sort_list_length, so it will keep fetching the
> full list each time. Also, I think that function could use a few more
> comments.

Good catch. Will fix.

> 3). I think you need to update psql so that \dT+ returns the enum
> elements in the right order.

Yeah. Will do.

I will post a revised patch soon.

cheers

andrew


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: recovery.conf location
Next
From: Simon Riggs
Date:
Subject: Re: recovery.conf location