Re: Stefan's bug (was: max_standby_delay considered harmful) - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Stefan's bug (was: max_standby_delay considered harmful)
Date
Msg-id AANLkTilEyO2-eBWSuvedrY6jVgE0tSn1Q9DnbyNqy_dw@mail.gmail.com
Whole thread Raw
In response to Re: Stefan's bug (was: max_standby_delay considered harmful)  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Mon, May 24, 2010 at 10:35 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Mon, May 24, 2010 at 10:26 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> This looks pretty reasonable to me, but I guess I feel like it would
>> be better to drive the CancelBackup() decision off of whether we've
>> ever reached PM_RUN rather than consulting XLogCtl.  It just feels
>> cleaner to me to drive all of the postmaster decisions off of the same
>> signalling mechanism rather than having a separate one (that only
>> works because it's used very late in shutdown when we theoretically
>> don't need a lock) just for this one case.
>
> Okay, how about the attached patch? It uses the postmaster-local flag
> "ReachedEndOfRecovery" (better name?) instead of XLogCtl one.

Looks good to me.  I will test and apply.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company


pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Stefan's bug (was: max_standby_delay considered harmful)
Next
From: Tom Lane
Date:
Subject: Re: Stefan's bug (was: max_standby_delay considered harmful)